Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false positives for flex in length-zero-no-unit #5315

Merged
merged 1 commit into from May 19, 2021
Merged

Fix false positives for flex in length-zero-no-unit #5315

merged 1 commit into from May 19, 2021

Conversation

jeddy3
Copy link
Member

@jeddy3 jeddy3 commented May 18, 2021

Which issue, if any, is this issue related to?

Closes #4831
Closes #5024

Is there anything in the PR that needs further explanation?

Implements #5024 (comment)

mattxwang
mattxwang approved these changes May 18, 2021
View reviewed changes
Copy link
Member

@mattxwang mattxwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly short and sweet, LGTM!

ybiquitous
ybiquitous approved these changes May 18, 2021
View reviewed changes
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏼

darwintantuco
darwintantuco approved these changes May 19, 2021
View reviewed changes
Copy link
Member

@darwintantuco darwintantuco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jeddy3 jeddy3 merged commit 52a67ab into v14 May 19, 2021
@jeddy3 jeddy3 deleted the issue-4831 branch May 19, 2021 12:16
@jeddy3
Copy link
Member Author

jeddy3 commented May 19, 2021

  • Fixed: length-zero-no-unit false positives for flex property (#5315).

@ybiquitous ybiquitous mentioned this pull request Sep 22, 2021
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Nov 1, 2021
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Dec 1, 2021
Closed
@ybiquitous ybiquitous mentioned this pull request Apr 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ybiquitous ybiquitous ybiquitous approved these changes

@mattxwang mattxwang mattxwang approved these changes

@darwintantuco darwintantuco darwintantuco approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jeddy3 @ybiquitous @mattxwang @darwintantuco